From 89848aa849fb84fb889b0a43c35decd0a6272c2d Mon Sep 17 00:00:00 2001 From: macniel Date: Mon, 26 Jan 2026 20:51:19 +0100 Subject: [PATCH] removes unneeded code --- src/module/data/skill.mjs | 1 - src/module/data/talent.mjs | 4 ---- src/module/dialog/attributeDialog.mjs | 8 -------- 3 files changed, 13 deletions(-) diff --git a/src/module/data/skill.mjs b/src/module/data/skill.mjs index db6eaa55..e32ec8c8 100644 --- a/src/module/data/skill.mjs +++ b/src/module/data/skill.mjs @@ -108,7 +108,6 @@ export class SkillDataModel extends BaseItem { async #talentRoll(rollMode) { const owner = this.parent.parent - // TODO: Migrate to DSARoll let roll1 = new Roll("3d20", owner.getRollData()); let evaluated1 = (await roll1.evaluate()) diff --git a/src/module/data/talent.mjs b/src/module/data/talent.mjs index 3f58144e..4c109b0b 100644 --- a/src/module/data/talent.mjs +++ b/src/module/data/talent.mjs @@ -51,16 +51,12 @@ export class Talent { * @returns {Promise<{tap: any, meisterlich: boolean, patzer: boolean, evaluatedRoll: Roll & {_evaluated: true, _total: number, readonly total: number}}>} */ async #talentRoll(data, rollMode) { - - - // TODO: Migrate to DSARoll const dsaDieRollEvaluated = await evaluateRoll("3d20", { value: data.taw, mod: data.mod, owner: data.owner, werte: [data.eigenschaften[data.eigenschaft1], data.eigenschaften[data.eigenschaft2], data.eigenschaften[data.eigenschaft3]], }) - return dsaDieRollEvaluated } diff --git a/src/module/dialog/attributeDialog.mjs b/src/module/dialog/attributeDialog.mjs index cc0b0b62..6f2b03bc 100644 --- a/src/module/dialog/attributeDialog.mjs +++ b/src/module/dialog/attributeDialog.mjs @@ -97,16 +97,8 @@ export class AttributeDialog extends HandlebarsApplicationMixin(ApplicationV2) { const targetValue = this._value + modValue - // TODO: Migrate to DSARoll let roll = await new Roll(`1d20`).evaluate() let diff = targetValue - roll.terms[0].results[0].result - let creationData = roll.toMessage({ - //speaker: ChatMessage.getSpeaker({actor: this.actor}), - //flavor: `${this._flaw ? "Schlechte " : ""}Eigenschaft: ${this._name}
Ergebnis: ${Math.abs(diff)}${diff > 0 ? " übrig" : " daneben"}`, - rollMode: game.settings.get('core', 'rollMode'), - }, { - create: false - }); const context = { attribute: this._name,